Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tzdata terminating host application v1.1 #766

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix tzdata terminating host application v1.1 #766

wants to merge 1 commit into from

Conversation

shegx01
Copy link

@shegx01 shegx01 commented Oct 21, 2024 •
edited
Loading

Summary of changes

Fix issue with tzdata v1.1 terminating the host application server

I'll review the commits, so I mostly want to understand the "why" rather than the "what"

Checklist

  • New functions have typespecs, changed functions were updated
  • Same for documentation, including moduledocs
  • Tests were added or updated to cover changes
  • Commits were squashed into a single coherent commit
  • Notes added to CHANGELOG file which describe changes at a high-level

@corroded
Copy link

@shegx01 could it be because of this? lau/tzdata#148

I keep encountering this in our logs - but it shouldn't terminate your host application server unless it fails to report errors or something? 🤔

@kaylenmistry
Copy link

@shegx01 could it be because of this? lau/tzdata#148

I keep encountering this in our logs - but it shouldn't terminate your host application server unless it fails to report errors or something? 🤔

Does not terminate the application, however would be nice to suppress this error log. Any chance we can proceed with this change? Thanks!

@bitwalker
Copy link
Owner

It isn't clear to me why this is actually a proper fix - you should be able to just mix deps.update tzdata to get 1.1.2+ with the current dependency constraint. Have you tried that?

@shegx01
Copy link
Author

shegx01 commented Dec 23, 2024

This is how we resolve the issue but for those that unlock dependencies or remove the deps.lock and reinstall, this issue would crept back in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitwalker bitwalker bitwalker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shegx01 @corroded @kaylenmistry @bitwalker